mirrors/gnab-rtl8812au
1
0
Fork 0
mirror of https://github.com/gnab/rtl8812au synced 2024-11-26 15:14:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address two -Wimplicit-fallthrough issues for gcc

Browse Source 
In rtw_mlme_ext.c, falling through makes perfect sense. I've
there replaced the ad hoc comment with the necessary gcc
attribute. In rtw_ap.c, the default case seems to agree with
the previous ones only by happenstance, so I've inserted an
actual break there. The warnings no longer fire.

Yes, there's a portable [[fallthrough]] -- for C++17. This
won't work on Clang, but neither will the kernel, nor this
Makefile.
This commit is contained in:
nick black 2019-10-11 05:49:16 -04:00
parent 744ebd966f
commit 3adef736e7
No known key found for this signature in database
GPG Key ID: 5F43400C21CBFACC
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/rtw_ap.c
View File

@ -2069,6 +2069,7 @@ static int rtw_ap_set_key(_adapter *padapter, u8 *key, u8 alg, int keyid, u8 set
case _TKIP_WTMIC_: case _TKIP_WTMIC_:
case _AES_: case _AES_:
keylen = 16; keylen = 16;
break;
default: default:
keylen = 16; keylen = 16;
} }

2
core/rtw_mlme_ext.c
View File

@ -709,7 +709,7 @@ void mgt_dispatcher(_adapter *padapter, union recv_frame *precv_frame)
ptable->func = &OnAuth; ptable->func = &OnAuth;
else else
ptable->func = &OnAuthClient; ptable->func = &OnAuthClient;
//pass through __attribute__ ((fallthrough));
case WIFI_ASSOCREQ: case WIFI_ASSOCREQ:
case WIFI_REASSOCREQ: case WIFI_REASSOCREQ:
_mgt_dispatcher(padapter, ptable, precv_frame); _mgt_dispatcher(padapter, ptable, precv_frame);