1
0
mirror of https://github.com/morrownr/8821cu-20210916.git synced 2024-09-07 15:46:46 +00:00

Addressed whines from "shellcheck -s sh"

This commit is contained in:
Miles Goodhew 2023-01-25 23:12:04 +11:00
parent 2954b29f7d
commit 8fe4a3bc2a

View File

@ -1,4 +1,4 @@
#!/bin/bash #!/bin/sh
# Purpose: Make it easier to edit the driver options file. # Purpose: Make it easier to edit the driver options file.
# #
@ -28,7 +28,7 @@ SCRIPT_VERSION="20230120"
OPTIONS_FILE="8821cu.conf" OPTIONS_FILE="8821cu.conf"
DEFAULT_EDITOR="$(cat default-editor.txt)" DEFAULT_EDITOR="$(cat default-editor.txt)"
if [[ $EUID -ne 0 ]]; then if [ "$(id -u)" -ne 0 ]; then
echo "You must run this script with superuser (root) privileges." echo "You must run this script with superuser (root) privileges."
echo "Try: \"sudo ./${SCRIPT_NAME}\"" echo "Try: \"sudo ./${SCRIPT_NAME}\""
exit 1 exit 1
@ -47,11 +47,15 @@ if ! command -v "${TEXT_EDITOR}" >/dev/null 2>&1; then
exit 1 exit 1
fi fi
# displays script name and version
echo ": ${SCRIPT_NAME} v${SCRIPT_VERSION}"
${TEXT_EDITOR} /etc/modprobe.d/${OPTIONS_FILE} ${TEXT_EDITOR} /etc/modprobe.d/${OPTIONS_FILE}
read -p "Do you want to apply the new options by rebooting now? [y/N] " -n 1 -r echo "Do you want to apply the new options by rebooting now? [y/N] "
read -r REPLY
echo # move to a new line echo # move to a new line
if [[ $REPLY =~ ^[Yy]$ ]]; then if [ "${REPLY}" = y ] || [ "${REPLY}" = Y ]; then
reboot reboot
fi fi