[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/Ui/DynamicTextChangedHandler.cs

@@ -1,4 +1,4 @@
 namespace Ryujinx.HLE.Ui
 {
     public delegate void DynamicTextChangedHandler(string text, int cursorBegin, int cursorEnd, bool overwriteMode);
-}
+}

src/Ryujinx.HLE/Ui/IDynamicTextInputHandler.cs

@@ -13,4 +13,4 @@ namespace Ryujinx.HLE.Ui
         void SetText(string text, int cursorBegin);
         void SetText(string text, int cursorBegin, int cursorEnd);
     }
-}
+}

src/Ryujinx.HLE/Ui/IHostUiHandler.cs

@@ -48,4 +48,4 @@ namespace Ryujinx.HLE.Ui
         /// </summary>
         IHostUiTheme HostUiTheme { get; }
     }
-}
+}

src/Ryujinx.HLE/Ui/Input/NpadReader.cs

@@ -9,7 +9,7 @@ namespace Ryujinx.HLE.Ui.Input
     class NpadReader
     {
         private readonly Switch _device;
-        private NpadCommonState[] _lastStates;
+        private readonly NpadCommonState[] _lastStates;
 
         public event NpadButtonHandler NpadButtonUpEvent;
         public event NpadButtonHandler NpadButtonDownEvent;
@@ -37,7 +37,7 @@ namespace Ryujinx.HLE.Ui.Input
             return buttons;
         }
 
-        private ref RingLifo<NpadCommonState> GetCommonStateLifo(ref NpadInternalState npad)
+        private static ref RingLifo<NpadCommonState> GetCommonStateLifo(ref NpadInternalState npad)
         {
             switch (npad.StyleSet)
             {
@@ -58,7 +58,7 @@ namespace Ryujinx.HLE.Ui.Input
             }
         }
 
-        public void Update(bool supressEvents=false)
+        public void Update(bool supressEvents = false)
         {
             ref var npads = ref _device.Hid.SharedMemory.Npads;
 
@@ -81,7 +81,11 @@ namespace Ryujinx.HLE.Ui.Input
             int firstEntryNum;
 
             // Scan the LIFO for the first entry that is newer that what's already processed.
-            for (firstEntryNum = fullKeyEntries.Length - 1; firstEntryNum >= 0 && fullKeyEntries[firstEntryNum].Object.SamplingNumber <= lastEntry.SamplingNumber; firstEntryNum--) ;
+            for (firstEntryNum = fullKeyEntries.Length - 1;
+                 firstEntryNum >= 0 && fullKeyEntries[firstEntryNum].Object.SamplingNumber <= lastEntry.SamplingNumber;
+                 firstEntryNum--)
+            {
+            }
 
             if (firstEntryNum == -1)
             {

src/Ryujinx.HLE/Ui/KeyPressedHandler.cs

@@ -3,4 +3,4 @@ using Ryujinx.Common.Configuration.Hid;
 namespace Ryujinx.HLE.Ui
 {
     public delegate bool KeyPressedHandler(Key key);
-}
+}

src/Ryujinx.HLE/Ui/KeyReleasedHandler.cs

@@ -3,4 +3,4 @@ using Ryujinx.Common.Configuration.Hid;
 namespace Ryujinx.HLE.Ui
 {
     public delegate bool KeyReleasedHandler(Key key);
-}
+}

src/Ryujinx.HLE/Ui/RenderingSurfaceInfo.cs

@@ -26,10 +26,20 @@ namespace Ryujinx.HLE.Ui
         public bool Equals(RenderingSurfaceInfo other)
         {
             return ColorFormat == other.ColorFormat &&
-                   Width       == other.Width       &&
-                   Height      == other.Height      &&
-                   Pitch       == other.Pitch       &&
-                   Size        == other.Size;
+                   Width == other.Width &&
+                   Height == other.Height &&
+                   Pitch == other.Pitch &&
+                   Size == other.Size;
+        }
+
+        public override bool Equals(object obj)
+        {
+            return obj is RenderingSurfaceInfo info && Equals(info);
+        }
+
+        public override int GetHashCode()
+        {
+            return BitConverter.ToInt32(BitConverter.GetBytes(((ulong)ColorFormat) ^ Width ^ Height ^ Pitch ^ Size));
         }
     }
 }